Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update/properties [email protected] #1112

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

abdul99ahad
Copy link
Contributor

@abdul99ahad abdul99ahad commented Feb 26, 2025

Related to : camunda-modeler #4818

Proposed Changes

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

CHANGELOG.md Outdated
@@ -6,6 +6,9 @@ All notable changes to [bpmn-js-properties-panel](https://github.com/bpmn-io/bpm

___Note:__ Yet to be released changes appear here._

`FIX`: trim trailing whitespaces from all input fields except expressions ([bpmn-io/properties-panel#401](https://github.com/bpmn-io/properties-panel/pull/401), [bpmn-io/properties-panel#402](https://github.com/bpmn-io/properties-panel/pull/402))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't there an upstream feature request? If so, we should link that one (as a primary reference), I think it was this one.

Also: I propose we frame this as a feature. It does not fix a bug, but improves the UX of overall property editing.

@@ -6,6 +6,9 @@ All notable changes to [bpmn-js-properties-panel](https://github.com/bpmn-io/bpm

___Note:__ Yet to be released changes appear here._

* `FEAT`: trim trailing whitespaces from all input fields except expressions ([bpmn-io/properties-panel#309](https://github.com/bpmn-io/properties-panel/issues/309))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be released as a minor, not a patch :)

@abdul99ahad abdul99ahad merged commit cd1320c into main Feb 27, 2025
9 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 27, 2025
@abdul99ahad abdul99ahad deleted the deps-update/[email protected] branch February 27, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants