-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create embedding example #302
Conversation
1159c91
to
9a3c4fc
Compare
We'll otherwise break embedding with existing applications, cf. bpmn-io/bpmn-js-examples#302.
This is accompained by bpmn-io/diagram-js#956. Checkout how the interaction improves with an explicit canvas focus and a native focus integration of
|
This is so great! This is a great case for the diagram-js change. I was wondering whether we should have "escape to blur". This does not work in Web |
Do you consider bpmn-io/diagram-js#956 along with this change? I.e. did you try the before and after behavior? |
Yes, I tried both and with the proposed change it works better to me. |
We'll otherwise break embedding with existing applications, cf. bpmn-io/bpmn-js-examples#302.
Proposed Changes
This adds an embedding example based off the previous work by @jarekdanielak:
What this example does:
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}