Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create embedding example #302

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Create embedding example #302

merged 2 commits into from
Dec 20, 2024

Conversation

nikku
Copy link
Member

@nikku nikku commented Dec 19, 2024

Proposed Changes

This adds an embedding example based off the previous work by @jarekdanielak:

capture q5Ru3U_optimized

What this example does:

  • Shows how different BPMN diagrams embed nicely within a larger website
  • Work friendly (enough) with each other
  • Shows there is work for us to do (i.e. "auto-focus" breaks with the site interaction)

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Dec 19, 2024
@nikku nikku force-pushed the keyboard branch 2 times, most recently from 1159c91 to 9a3c4fc Compare December 19, 2024 14:41
nikku added a commit to bpmn-io/diagram-js that referenced this pull request Dec 19, 2024
We'll otherwise break embedding with existing applications, cf.
bpmn-io/bpmn-js-examples#302.
@nikku
Copy link
Member Author

nikku commented Dec 19, 2024

This is accompained by bpmn-io/diagram-js#956.

Checkout how the interaction improves with an explicit canvas focus and a native focus integration of navigation/* modules:

npx @bpmn-io/sr bpmn-io/bpmn-js-examples#keyboard -l bpmn-io/diagram-js#optional-autofocus -c 'npm start -w embedding'

capture rF7ska_optimized

@nikku nikku marked this pull request as ready for review December 19, 2024 18:01
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Dec 19, 2024
@barmac
Copy link
Member

barmac commented Dec 20, 2024

This is so great! This is a great case for the diagram-js change.

I was wondering whether we should have "escape to blur". This does not work in Web input elements, but works for the address bar. I guess we will stick to the Web platform behavior.

@nikku
Copy link
Member Author

nikku commented Dec 20, 2024

Do you consider bpmn-io/diagram-js#956 along with this change? I.e. did you try the before and after behavior?

@barmac
Copy link
Member

barmac commented Dec 20, 2024

Yes, I tried both and with the proposed change it works better to me.

@barmac barmac merged commit 7fd9b08 into main Dec 20, 2024
4 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 20, 2024
@barmac barmac deleted the keyboard branch December 20, 2024 08:57
nikku added a commit to bpmn-io/diagram-js that referenced this pull request Dec 20, 2024
We'll otherwise break embedding with existing applications, cf.
bpmn-io/bpmn-js-examples#302.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants