Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpfd: Use tc dispatcher from container image #817

Merged
merged 3 commits into from
Nov 15, 2023
Merged

bpfd: Use tc dispatcher from container image #817

merged 3 commits into from
Nov 15, 2023

Conversation

dave-tucker
Copy link
Collaborator

No description provided.

@dave-tucker dave-tucker requested a review from a team as a code owner November 13, 2023 13:33
@netlify Netlify
Copy link

netlify bot commented Nov 13, 2023 •
edited
Loading

✅ Deploy Preview for bpfd ready!

Name Link
🔨 Latest commit f5378e0
🔍 Latest deploy log https://app.netlify.com/sites/bpfd/deploys/6554cfa203a8050008da5db6
😎 Deploy Preview https://deploy-preview-817--bpfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (df94aab) 27.21% compared to head (f5378e0) 27.06%.
Report is 10 commits behind head on main.

Files Patch % Lines
bpfd/src/multiprog/tc.rs 0.00% 37 Missing ⚠️
bpfd/src/serve.rs 0.00% 20 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
- Coverage   27.21%   27.06%   -0.16%     
==========================================
  Files          35       35              
  Lines        7257     7298      +41     
==========================================
  Hits         1975     1975              
- Misses       5141     5182      +41     
  Partials      141      141

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astoycos
Copy link
Member

One comment otherwise LGTM

@dave-tucker
test: Always stream bpfd logs
2b3d423 
Signed-off-by: Dave Tucker <[email protected]>
@dave-tucker
bpfd: Fix use of tokio::join
f5378e0 
From the docs, join doesn't spawn. If we want parallelism, we're
supposed to call spawn first. This is necessary so that we can
spawn the image_manager thread before the state reconstruction
occurs.

Signed-off-by: Dave Tucker <[email protected]>
astoycos
astoycos approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@astoycos astoycos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit f9c86e9 into bpfman:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astoycos astoycos astoycos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dave-tucker @astoycos