Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken link the readme and few minor edits #33

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

msherif1234
Copy link
Contributor

few minor edits to readme

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.08%. Comparing base (cc91164) to head (4a4309b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   27.08%   27.08%           
=======================================
  Files          81       81           
  Lines        6844     6844           
=======================================
  Hits         1854     1854           
  Misses       4806     4806           
  Partials      184      184           
Flag Coverage Δ
unittests 27.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Billy99 Billy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one comment

README.md Outdated Show resolved Hide resolved
anfredette
anfredette previously approved these changes Jun 28, 2024
Copy link
Contributor

@anfredette anfredette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msherif1234 msherif1234 force-pushed the update-readme branch 2 times, most recently from 01905fe to 1ae1625 Compare July 1, 2024 16:50
@msherif1234 msherif1234 requested a review from anfredette July 1, 2024 16:59
anfredette
anfredette previously approved these changes Jul 1, 2024
Copy link
Contributor

@anfredette anfredette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

astoycos
astoycos previously approved these changes Jul 1, 2024
Copy link
Member

@astoycos astoycos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @msherif1234!

Billy99
Billy99 previously approved these changes Jul 1, 2024
Copy link
Contributor

@Billy99 Billy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@anfredette anfredette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anfredette anfredette merged commit a96351e into bpfman:main Jul 2, 2024
12 checks passed
msherif1234 pushed a commit to msherif1234/bpfman-operator that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants