Fixups for pr #6 #31
Merged
Fixups for pr #6 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was there, but got dropped at some point. Also, added a strings.ToLower() to sanitize(). Signed-off-by: Andre Fredette <[email protected]>
|
hmm not sure why the pod watch was dropped either changes LGTM |
msherif1234
approved these changes
Jun 21, 2024
msherif1234
pushed a commit
to msherif1234/bpfman-operator
that referenced
this pull request
Oct 30, 2024
…/ocp-bpfman Update ocp-bpfman to a08b3a0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add watch on pod events back to
BpfApplicationReconciler. It was there but got dropped at some point.Also, added a
strings.ToLower()to the namesanitize()function.