ci: add Podman validation to the build-images step #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a matrix in the Kubernetes integration tests job to support both Docker and Podman for image builds. Add `oci_bin` as a matrix entry to control which container runtime is used. Conditionally install Podman when required and build images using the appropriate runtime. Ensure that integration tests only run with Docker by skipping them when Podman is used, avoiding unnecessary test runs. This change ensures Podman compatibility for image builds while keeping the test process the same for Docker. Signed-off-by: Andrew McDermott <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 27.61% 27.61%
=======================================
Files 81 81
Lines 6999 6999
=======================================
Hits 1933 1933
Misses 4877 4877
Partials 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Some previous commentary on why this PR may add little value: #121 (comment) |
dave-tucker
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a matrix in the Kubernetes integration tests job to support both Docker and Podman for image builds. Add
oci_binas a matrix entry to control which container runtime is used. Conditionally install Podman when required and build images using the appropriate runtime.Ensure that integration tests only run with Docker by skipping them when Podman is used, avoiding unnecessary test runs. This change ensures Podman compatibility for image builds while keeping the test process the same for Docker.