Fix BUILDPLATFORM redefinition issue in non-OpenShift Containerfiles

Removed the hardcoded `ARG BUILDPLATFORM=linux/amd64` from `Containerfile.bpfman-agent` and `Containerfile.bpfman-operator`. This change addresses an issue where Podman fails to build the images if `BUILDPLATFORM` is redefined. By removing the redefinition, the build process is made compatible with Podman. This change remains compatible with Docker, which is more lenient with ARG redefinitions. Fixes: #120 Signed-off-by: Andrew McDermott <[email protected]>
bpfman · Sep 2, 2024 · 534da80 · 534da80
1 parent 076e261
commit 534da80
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/Containerfile.bpfman-agent b/Containerfile.bpfman-agent
@@ -1,6 +1,4 @@
 # Build the manager binary
-ARG BUILDPLATFORM=linux/amd64
-
 FROM --platform=$BUILDPLATFORM docker.io/library/golang:1.22 AS bpfman-agent-build
 
 # The following ARGs are set internally by docker/build-push-action in github actions

diff --git a/Containerfile.bpfman-operator b/Containerfile.bpfman-operator
@@ -1,6 +1,4 @@
 # Build the manager binary
-ARG BUILDPLATFORM=linux/amd64
-
 FROM --platform=$BUILDPLATFORM docker.io/library/golang:1.22 AS bpfman-operator-build
 
 ARG BUILDPLATFORM