add max/min width/height for images #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please revert changes in |
|
build files are now reverted. Can you create a build/release for npm so I can use this new feature right away? Thank you for your support! |
|
Merged. Thanks. |
Closed
ardean
added a commit
to ardean/pdfmake
that referenced
this pull request
Apr 7, 2017
Merge pull request bpampuch#938 from ardean/master
baltpeter
added a commit
to datenanfragen/letter-generator
that referenced
this pull request
Nov 17, 2022
The problem of the huge signature was caused by #3. Removing the fixed `width` from the signature caused the image to scale to the page width (even though the docs say this should mean the image's original size *shrug*). Instead, we now set a `maxWidth`, which solves both problems. I haven't actually found any documentation for this feature but it was implemented in bpampuch/pdfmake#938.
zner0L
pushed a commit
to datenanfragen/letter-generator
that referenced
this pull request
Dec 5, 2022
The problem of the huge signature was caused by #3. Removing the fixed `width` from the signature caused the image to scale to the page width (even though the docs say this should mean the image's original size *shrug*). Instead, we now set a `maxWidth`, which solves both problems. I haven't actually found any documentation for this feature but it was implemented in bpampuch/pdfmake#938.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds max/min width/height for #14
please let me know if there is something to change