Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/0.1/superscript (with automatically reduced font size) #2128

Merged
merged 8 commits into from
Nov 19, 2020
Merged

Feature/0.1/superscript (with automatically reduced font size) #2128

merged 8 commits into from
Nov 19, 2020

Conversation

moshensky
Copy link

@moshensky moshensky commented Nov 16, 2020 •
edited
Loading

Basic functionality for feature request #36

This is mostly @rabraha3 PR #1809.

I've addressed @liborm85 comment and made sure that the width of the text is calculated properly accounting for reduced font size.

rabraha3 and others added 8 commits August 1, 2019 16:39
@rabraha3
Add simple superscript to the 0.1 branch -- move text baseline up whe…
e437ddb 
…n inline.sup is true
@rabraha3
Add simple subscript, with default offsets. Works the same way as sup…
13553b3 
…erscript, only it moves the baseline DOWN.
@rabraha3
Merge branch '0.1' of https://github.com/bpampuch/pdfmake into 0.1
0065290
@rabraha3
Merge branch '0.1' into feature/0.1/superscript
1caf9bc
@rabraha3
Build fail because I used 'let' instead of 'var'
273523c
@rabraha3
Update examples/styling_properties.js with one superscript and one su…
c7ef78d 
…bscript example.
Merge branch '0.1' into feature/0.1/superscript
c8be117 
* 0.1: (60 commits)
  fix auto page height for table bpampuch#2005
  0.1.68
  update dependencies
  fixed check window exists bpampuch#2037
  0.1.67
  refresh pdf examples
  fix for overrides window.Promise EP bpampuch#2026
  reformat
  bug-2021-bad-svg-parsing * switch to using xmldoc
  backport to 0.1: loading images via URL in browser
  bug-2021-bad-svg-parsing * fix for writeDimensions()
  bug-2021-bad-svg-parsing * failing test for writeDimensions()
  bug-2021-bad-svg-parsing * fix to ignore comments when identifying <svg> tag
  bug-2021-bad-svg-parsing * add failing tests
  0.1.66
  fonts available in cdn
  backport to 0.1: support for loading raw font files by url address via http(s) protocol for browser usage
  define node version in package.json
  fix for babel bpampuch#1846
  travis - run first on linux
  ...
Fix parasite white space left after supscript or subscript and next c…
9039447 
…haracter and enable default font size reduction.
@liborm85 liborm85 merged commit 7a024e1 into bpampuch:0.1 Nov 19, 2020
@liborm85
Copy link
Collaborator

Merged. Thanks.

@liborm85 liborm85 mentioned this pull request Nov 19, 2020
Closed
liborm85 added a commit that referenced this pull request Nov 19, 2020
@liborm85
superscript and subscript #36 (PR #2128)
99acfe9 
0.1 branch commit: 7a024e1
@liborm85 liborm85 mentioned this pull request Nov 19, 2020
Closed
@kryops kryops mentioned this pull request Mar 6, 2021
Merged
7 tasks
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
@weisborg
Copy link

Is it possible to get the underline to be under the letter instead of underlining where the letter would be if not sup/sub? Example- The Numero symbol is a big N with a Superscript o that is underlined right under the o. I know there is actually a char for this too that has it all in one position, but it is way too tiny in a PDF to tell what it is, so I make it like this. It looks ok with no underline too, but I was just seeing if it is able to be done. Currently using the Version 2 branch since 3 is beta and has breaking changes...we originally started with the Version 1.

@moshensky moshensky deleted the feature/0.1/superscript branch February 16, 2023 06:50
@moshensky moshensky restored the feature/0.1/superscript branch February 16, 2023 06:58
@moshensky moshensky deleted the feature/0.1/superscript branch February 16, 2023 06:58
@moshensky
Copy link
Author

Is it possible to get the underline to be under the letter instead of underlining where the letter would be if not sup/sub? Example- The Numero symbol is a big N with a Superscript o that is underlined right under the o. I know there is actually a char for this too that has it all in one position, but it is way too tiny in a PDF to tell what it is, so I make it like this. It looks ok with no underline too, but I was just seeing if it is able to be done. Currently using the Version 2 branch since 3 is beta and has breaking changes...we originally started with the Version 1.

It might be better to open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moshensky @liborm85 @weisborg @rabraha3