Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter in /html does not work properly #120

Closed
quasarea opened this issue Jun 6, 2017 · 1 comment
Closed

Filter in /html does not work properly #120

quasarea opened this issue Jun 6, 2017 · 1 comment
Labels

Comments

@quasarea
Copy link

quasarea commented Jun 6, 2017

Same query, same filter yields different results:
15 hits - http://localhost:8080/?q=%22Microsoft.Office.Interop.Excel%22&lan=MSBuild%20scripts
0 hits - http://localhost:8080/html?q=%22Microsoft.Office.Interop.Excel%22&lan=MSBuild%20scripts

I noticed that in even result address gets different, maybe related to space in language name:
http://localhost:8080/?q=%22Microsoft.Office.Interop.Excel%22&lan=MSBuild%20scripts
http://localhost:8080/html/?q=%22Microsoft.Office.Interop.Excel%22&lan=MSBuild+scripts

@boyter boyter added the bug label Jun 13, 2017
@boyter
Copy link
Owner

boyter commented Jun 13, 2017

As you guessed it is because of the space. I changed the way that was handled to fix a bug on the JS side and looks like it was not reflected on the HTML.

TODO - Improve integration tests to cater for this to avoid it reoccurring and then fix the bug.

@boyter boyter closed this as completed in 99a494b Jun 14, 2017
@boyter boyter mentioned this issue Jun 14, 2017
boyter added a commit that referenced this issue Jun 14, 2017
 - BREAKING CHANGE Changed validation of repository names such that they must be alphanumeric, _ or - with client and server side validation
 - BREAKING CHANGE Fix spelling of check_filerepo_chages to check_filerepo_changes for properties file
 - Set follow symlinks to be configurable through properties file #99
 - Clicking Remove will also clear the text box filters #98
 - Improved stop/reset jobs logic, deleted jobs persist on searchcode restart #41
 - Add logic to calculate project stats by lines not files and display next to existing #103
 - Deep guess logic added to guess a files type based on keyword heuristic's #105
 - Additional languages added to classifier database, F#, Mathematica, Parrot, Puppet, Rakefile, PKGBUILD, Cargo, Lock, License
 - API auditing via logs added #57
 - Search results now have RSS feed #114
 - Can add custom HTML/CSS/JS to all pages #107
 - Add average index time seconds to repo overview page #118
 - Fix bug where unable to filter on html page #120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants