[BUG] Fix subdomain install adding extra site. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houdmont
approved these changes
Apr 23, 2021
strayobject
approved these changes
Apr 23, 2021
When using a subdomain install, an extra site was being created when the site key was an empty string, e.g. example.com .example.com sub.example.com When desired outcome is: example.com sub.example.com This PR updates it so that for subdomain installs, if the site key is an empty string it will no longer create a site with an empty prefix.
jenkoian
force-pushed
the
fix-main-subdomain-issue
branch
from
2f5c65e to
8598df4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a subdomain install, an extra site was being created when the
site key was an empty string, e.g.
example.com
.example.com
sub.example.com
When desired outcome is:
example.com
sub.example.com
This PR updates it so that for subdomain installs, if the site key is an
empty string it will no longer create a site with an empty prefix.