Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Refactor for 1.x #16

Merged
merged 1 commit into from
Mar 14, 2022
Merged

[REFACTOR] Refactor for 1.x #16

merged 1 commit into from
Mar 14, 2022

Conversation

jenkoian
Copy link
Contributor

  • Adds some unit tests
  • Throws exception in cases where classes don't exist or can't be
    instantiated
  • Tidies up the code a little
  • Adds more types where appropriate

[REFACTOR] Refactor for 1.x.
5bf5ba5 
* Adds some unit tests
* Throws exception in cases where classes don't exist or can't be
  instantiated
* Tidies up the code a little
* Adds more types where appropriate
@jenkoian jenkoian merged commit 03e1806 into master Mar 14, 2022
@jenkoian jenkoian deleted the quality-refactor branch March 14, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonny-bull jonny-bull jonny-bull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenkoian @jonny-bull