[REFACTOR] Refactor to PSR-12 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenkoian
force-pushed
the
refactor-for-1x
branch
10 times, most recently
from
6b3b8e0 to
552a033
Compare
andrewjt71
approved these changes
Mar 9, 2022
|
Some minor feedback: This PR is also:
May be worth adding these to the commit message. Also, the commit isn't aligned with https://boxukltd.atlassian.net/wiki/spaces/BUDH/pages/160276496/Commit+Messages Approved though as code changes look good Edit: |
This is the first commit in preparation for a version 1 and includes the following: * Refactor code base to PSR-12 * Includes php-cs-fixer to enforce PSR-12 * Uses PSR-4 and utilises the composer autoloader * Renames the `php` directory to `src` * Dropped PHP 5.6 support * Runs `composer update` instead of `composer install` on travis due to no lock file being committed it makes sense to always use update. Future PRs will likely drop support for travis altogether in favour ot GH actions, the main reason for this is the PHP8.1 build doesn't seem to run and I can't work out why.
jenkoian
force-pushed
the
refactor-for-1x
branch
from
552a033 to
5d496ef
Compare
|
@andrewjt71 cheers! All points addressed and commit message beefed up 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first commit in preparation for a version 1 and includes the
following:
phpdirectory tosrccomposer updateinstead ofcomposer installon travis due tono lock file being committed it makes sense to always use update.
Future PRs will likely drop support for travis altogether in favour ot
GH actions, the main reason for this is the PHP8.1 build doesn't seem to
run and I can't work out why.