Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default credential provider chain for AWS #51

Merged

Conversation

jordanjennings
Copy link
Contributor

fixes #50

@jordanjennings jordanjennings force-pushed the aws-default-credential-chain branch from e5c2cda to a6998e1 Compare March 11, 2022 17:01
Copy link
Contributor

@matthewdevenny matthewdevenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove the SessionProvider and corresponding methods

Signed-off-by: Jordan Jennings <[email protected]>
@jordanjennings jordanjennings force-pushed the aws-default-credential-chain branch from 2a8b1a2 to 33a0033 Compare March 11, 2022 17:30
Copy link
Contributor

@matthewdevenny matthewdevenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jordanjennings jordanjennings merged commit 0a4257d into boxboat:develop Mar 14, 2022
@jordanjennings jordanjennings deleted the aws-default-credential-chain branch March 14, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AWS IAM Roles for Service Accounts
2 participants