-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish an implementation metadata file suitable for use by json-schema.org #1408
Publish an implementation metadata file suitable for use by json-schema.org #1408
Conversation
Also @benjagm what all keys do you expect to be included in this API corresponding to an implementation? |
Only if you view it in a browser, for API consumption it doesn't matter either way. (So yes let's remove it). I'm confused though., didn't we merge this already? Having a look. |
Nah we didn't. I had that PR opened but later closed it. This |
Looks like Benja shared what's expected here -- so all we need is a mapping where the keys are source URLs for implementations, and the values should have:
We can skip everything else for now. (EDIT: Also the badges URLs, as we may as well simply include that so that the JSON Schema folks don't need to recalculate it). |
Doing the changes. |
@Julian Is there a way of generating those URLs programmatically using |
I think that logic lives in the UI code unfortunately right now which I think you've seen last -- so not directly -- you could have a small typescript script maybe which imports the UI file, but not sure that's simpler than doing the hairy thing again :/ |
@Julian made the final changes. Tested on my local works fine. You can have a look here --> https://adwait-godbole.github.io/bowtie/api/v1/json-schema-org/implementations |
Thanks! Let's give it a shot. Well done. |
It would be better if you could manually trigger this workflow once the CI passes, so we know if it works or not. |
I kicked a release! |
I hope for e.g. the below output format is fine right ?
|
Ah, close, I think ideally the keys in the |
Probably you can also shorten the key name to |
Yup makes sense! |
Fixes #1312
@Julian can you review this one so that we can get this file available to @benjagm ASAP. Also earlier you had told me to remove the
.json
extension from the file, are you still ok with that ? Removing that extension directly downloads the file onto your desktop rather than opening on the Bowtie website.📚 Documentation preview 📚: https://bowtie-json-schema--1408.org.readthedocs.build/en/1408/