Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dimension problem when using create_bout_ds_list #61

Closed
rdoyle45 opened this issue Oct 29, 2019 · 1 comment
Closed

Dimension problem when using create_bout_ds_list #61

rdoyle45 opened this issue Oct 29, 2019 · 1 comment

Comments

@rdoyle45
Copy link
Collaborator

To test the operation of the collect function in #59 I am using the create_bout_ds_list function from test_load, which was used to generate test data for test_animate.

The problem lies with the keep_xboundaries and keep_yboundaries kwargs of _auto_open_mfboutdataset. If True, these should increase the x and y dimensions, respectively, but it has the opposite effect on the data from create_bout_ds_list.

I have tried it with actual BOUT++ data, and the parameters behave as expected. It seems to be specific to create_bout_ds_list data, but I can't ascertain why this is.
@rdoyle45
Copy link
Collaborator Author

Premature issue, I have not checked with changes made in #55

johnomotani pushed a commit that referenced this issue Dec 11, 2019
@rdoyle45
Holding commit many more edits to be made - z-dim indexing option upd…
3624159 
…ated and tests added (tests will fail if xguards and yguards parameters change, issue being looked at in #61)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rdoyle45