imghelper: set AWS_CA_BUNDLE if cert is available #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumukhballal
force-pushed
the
set_aws_ca_bundle_cert
branch
from
5a4fb00 to
60113ea
Compare
bcressey
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
You can try setting CURL_CA_BUNDLE instead to see if that overrides the libcurl default.
(It's the AWS SDK for C++ behavior you're trying to change, not the KMS proxy.)
This looks OK to me; it's a bit rude to clobber an SDK file, but it should be fine for now.
cbgbt
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
If a CA-Bundle is set using a secret mount and present, it will update the SDK to use these certs instead. Also sets the aws variable AWS_CA_BUNDLE if there is a secret mount. The secret mount is created when we pass a CABundle via override using the environment variable
BUILDSYS_CACERTS_BUNDLE_OVERRIDE.Note: I tried setting
SSL_CERT_FILEvariable instead but it causes the curl utility in aws-kms-pkcs11 to fail.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.