updata: allow specifying a start time for waves #927
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, wave start times would always be relative to when you ran updata,
meaning you'd have to hold off on running updata until you were ready to start
a release process. This lets you (optionally) pick any start time for the
start of the waves, and the given start_after offsets will be relative to that
time.
To keep the code and the deployment process simple, this also requires
specifying relative offsets in wave definition files, rather than absolute
times; we only used relative offsets anyway so that the files were reusable and
it was easier to understand the delays between waves, but this codifies that
behavior.
This caused pain in the 0.3.3 release, requiring rework and a changed deployment plan, so I wanted to fix it before the next release.
Testing done:
Start with no waves:
Add waves with no
start-at
argument, as we have before:We see the waves are relative to when I ran the command, as before.
Now run with a
start-at
next month, and we see the waves start next month as expected:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.