Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrations:Update the public control container migrations #4388

Merged

Conversation

vyaghras
Copy link
Contributor

@vyaghras vyaghras commented Feb 7, 2025

Description of changes:
We need to use ReplaceStringMigration for public container. Also the old version are plain string instead of schnauzer generator string.

Testing done:

  • Update to 1.33.0 from 1.28.0 having the old migrations as is.

apiclient get settings.host-containers
{
  "settings": {
    "host-containers": {
      "admin": {
        "enabled": true,
        "source": "328549459982.dkr.ecr.us-west-2.amazonaws.com/bottlerocket-admin:v0.11.16",
        "superpowered": true,
        "user-data": "eyJzc2giOnsiYXV0aG9yaXplZC1rZXlzIjpbXX19"
      },
      "control": {
        "enabled": true,
        "source": "328549459982.dkr.ecr.us-west-2.amazonaws.com/bottlerocket-control:v0.7.20",
        "superpowered": false
      }
    }
  }
}
bas

apiclient get settings.host-containers
{
  "settings": {
    "host-containers": {
      "admin": {
        "enabled": true,
        "source": "328549459982.dkr.ecr.us-west-2.amazonaws.com/bottlerocket-admin:v0.11.14",
        "superpowered": true,
        "user-data": "eyJzc2giOnsiYXV0aG9yaXplZC1rZXlzIjpbXX19"
      },
      "control": {
        "enabled": true,
        "source": "328549459982.dkr.ecr.us-west-2.amazonaws.com/bottlerocket-control:v0.7.18",
        "superpowered": false
      }
    }
  }
}
  • Update to 1.33.0 from 1.28.0 having the old migrations updated.
apiclient get settings.host-containers
{
  "settings": {
    "host-containers": {
      "admin": {
        "enabled": true,
        "source": "328549459982.dkr.ecr.us-west-2.amazonaws.com/bottlerocket-admin:v0.11.16",
        "superpowered": true,
        "user-data": "eyJzc2giOnsiYXV0aG9yaXplZC1rZXlzIjpbXX19"
      },
      "control": {
        "enabled": true,
        "source": "328549459982.dkr.ecr.us-west-2.amazonaws.com/bottlerocket-control:v0.7.20",
        "superpowered": false
      }
    }
  }
}


apiclient get settings.host-containers
{
  "settings": {
    "host-containers": {
      "admin": {
        "enabled": true,
        "source": "328549459982.dkr.ecr.us-west-2.amazonaws.com/bottlerocket-admin:v0.11.14",
        "superpowered": true,
        "user-data": "eyJzc2giOnsiYXV0aG9yaXplZC1rZXlzIjpbXX19"
      },
      "control": {
        "enabled": true,
        "source": "328549459982.dkr.ecr.us-west-2.amazonaws.com/bottlerocket-control:v0.7.18",
        "superpowered": false
      }
    }
  }
}

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@cbgbt cbgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do some kind of catchup migration to catch customers who are stranded on 0.7.18 and 0.7.19?

Copy link
Contributor

@cbgbt cbgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems fine to me!

For the commit messages, make sure to add a space after migrations:.

@vyaghras vyaghras force-pushed the fix-public-control-migrations branch from 94d6e43 to 3e14628 Compare February 7, 2025 19:46
We need to use ReplaceStringMigration for public container.
Also the old version are plain string instead of schnauzer generator
string.
We have updated the Control host container to version 0.7.19
in Bottlerocket image version 1.30.0, but due to a miss in migration
the control container version has not been updated since
Bottlerocket version 1.29.0. This migration will update all those
containers to Control container version 0.7.19.
We have updated the Control host container to version 0.7.20
in Bottlerocket image version 1.31.0, but due to a miss in migration
the control container version has not been updated since
Bottlerocket version 1.29.0. This migration will update all those
containers to Control container version 0.7.20.
@vyaghras vyaghras force-pushed the fix-public-control-migrations branch from 3e14628 to 5365f78 Compare February 7, 2025 19:49
@vyaghras vyaghras merged commit 7e3976b into bottlerocket-os:develop Feb 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants