Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define FIPS variants #4274

Merged
merged 11 commits into from
Nov 7, 2024
Merged

Conversation

arnaldo2792
Copy link
Contributor

@arnaldo2792 arnaldo2792 commented Oct 30, 2024

Issue number:

Related to: #1667

Description of changes:

This defines the AWS and VMware FIPS variants. I used my own core kit that includes all the FIPS-related work provided by the Core Kit, so the variants used FIPS-constrained go and rust binaries.

Testing done:

  • Quick tests for AWS variants, both arches
  • Conformance tests for AWS variants, both arches
  • Migration tests for AWS variants, both arches
  • Quick tests for VMware variants
  • Conformance tests for VMware variants
  • Migration tests for VMware variants

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@yeazelm yeazelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming all the testing passes! Nice!

@arnaldo2792
Copy link
Contributor Author

(Forced push fixes CI failures)

Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
@arnaldo2792
Copy link
Contributor Author

(Forced push rebases develop and drops hack commit to use own core kit)

@arnaldo2792 arnaldo2792 marked this pull request as ready for review November 7, 2024 02:10
@arnaldo2792 arnaldo2792 merged commit 566ee77 into bottlerocket-os:develop Nov 7, 2024
2 checks passed
@arnaldo2792 arnaldo2792 deleted the fips-variants branch November 7, 2024 18:11
@cbgbt cbgbt mentioned this pull request Nov 7, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants