Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrations: archive previous releases #4014

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

bcressey
Copy link
Contributor

Issue number:
Previously: #3633, #2800, #2606, ...

Description of changes:
This avoids rebuilding existing migrations and reduces build times.

Testing done:
Builds work.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

This avoids rebuilding existing migrations and reduces build times.

Signed-off-by: Ben Cressey <[email protected]>
@bcressey bcressey requested review from webern and arnaldo2792 May 31, 2024 18:10
Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there consequences to upgrade/downgrade workflows of archiving, e.g. 1.20 so soon?

@bcressey
Copy link
Contributor Author

Are there consequences to upgrade/downgrade workflows of archiving, e.g. 1.20 so soon?

Not necessarily but it depends on how the upgrade/downgrade workflow is handled.

As I understand it, the problem is with a sequence like this:

build old version
build new version
sync repo

The old version will create a migrations RPM during os build with all the older migration binaries. However, if that's not synced up to the repo, then when the new version is built, a new migrations RPM will be created with only the subset of current migration binaries.

I expect a sequence like this would be fine:

build old version
sync repo
build new version
sync repo

@bcressey bcressey merged commit bd2709b into bottlerocket-os:develop Jun 4, 2024
33 checks passed
@bcressey bcressey deleted the archive-migrations branch June 4, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants