Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rust 1.72.0 lints/warnings #3365

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

etungsten
Copy link
Contributor

Issue number:

N/A

Description of changes:
Preemptively address newly activated lints and warnings in rust 1.72.0

    sources: fix 1.72.0 clippy warnings
    tools: fix 1.72.0 clippy warnings
    chore: explicity set cargo feature resolver version to 2
    
    This gets rid of a warning that comes with rust 1.72.0. This does not
    impact any of our existing crates since they're all on edition 2021.
    
    See https://github.com/rust-lang/cargo/issues/10112

Testing done:
cargo clippy returns no warnings across sources/tools workspaces.
Unit tests pass

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

This gets rid of a warning that comes with rust 1.72.0. This does not
impact any of our existing crates since they're all on edition 2021.

See rust-lang/cargo#10112
@etungsten etungsten merged commit f3ccf89 into bottlerocket-os:develop Aug 28, 2023
@etungsten etungsten deleted the rust172lints branch August 28, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants