kubelet: Enable setting cpuManagerPolicyOptions #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Apr 6, 2023
sources/api/migration/migrations/v1.14.0/kubelet-config-settings/src/main.rs
Outdated
Show resolved
Hide resolved
stmcginnis
force-pushed
the
cpu-policy-options
branch
from
9a41e52 to
8661e6d
Compare
bcressey
approved these changes
Apr 9, 2023
stmcginnis
force-pushed
the
cpu-policy-options
branch
from
8661e6d to
63d3ada
Compare
|
Rebased to resolve merge conflict with |
stmcginnis
force-pushed
the
cpu-policy-options
branch
from
63d3ada to
1b31391
Compare
This adds a new `settings.kubernetes.cpu-manager-policy-options` setting to allow configuring the kubelet cpuManagerPolicyOptions. When the CPU manager policy is set to "static", these options allow affecting the behavior of CPU allocation for pods. Signed-off-by: Sean McGinnis <[email protected]>
stmcginnis
force-pushed
the
cpu-policy-options
branch
from
1b31391 to
8cb2651
Compare
jpmcb
approved these changes
Apr 24, 2023
gthao313
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #2342
Description of changes:
This adds a new
settings.kubernetes.cpu-manager-policy-optionssetting to allow configuring the kubelet cpuManagerPolicyOptions. When the CPU manager policy is set to "static", these options allow affecting the behavior of CPU allocation for pods.The only supported policy option at this point is
full-pcpus-onlyas it is the only one that is not hidden by an alpha feature gate. More options can be supported later as they leave alpha.This change could have been included with #2930, but that PR is already getting quite large. So at this point it will probably be better dealing with merge conflicts than inflating that further. If one or the other doesn't make it in time for the next release they can also be divided up and updated to have the correct migration for their ultimate release version.
Testing done:
Deployed built image and applied these settings:
Verified the
/etc/kubernetes/kubelet/configfile rendered as expected:Checked
systemctl status kubeletand made sure the service was healthy and reviewed logs to make surekubeletwas able to start up and recognize the new configuration.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.