Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update to tokio v1 reqwest v0.11 tough v0.11 #1370

Merged
merged 1 commit into from
Mar 10, 2021
Merged

tools: update to tokio v1 reqwest v0.11 tough v0.11 #1370

merged 1 commit into from
Mar 10, 2021

Conversation

webern
Copy link
Contributor

@webern webern commented Mar 9, 2021

Issue number:

Half of #1269

Description of changes:

Update the tools workspace to tokio v1

Testing done:

  • Checked Cargo.lock to make sure only one version of tokio is in use.
  • Ran cargo make ami (with multiple regions and accounts in the Infra.toml).
  • Ran cargo make repo, ran an instance and checked the repo.
  • Ran cargo make ssm(with multiple regions and accounts in the Infra.toml).

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

tjkirch
tjkirch approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. (Un?)fortunately tokio 1.3 and reqwest 0.11.2 came out today. It should be an easy update on top of this..?

tools/Cargo.lock Show resolved Hide resolved
tools/pubsys/src/aws/ssm/ssm.rs Show resolved Hide resolved
@webern webern mentioned this pull request Mar 10, 2021
Closed
@webern
Copy link
Contributor Author

webern commented Mar 10, 2021

webern force-pushed the webern:tools-tokio-v1 branch from 5427ac7 to 18e9db3

Update tokio and reqwest to the latest versions.

@webern
Copy link
Contributor Author

webern commented Mar 10, 2021

webern force-pushed the webern:tools-tokio-v1 branch from 18e9db3 to a7f0037

Rebase

@webern webern requested review from zmrow and etungsten March 10, 2021 20:38
srgothi92
srgothi92 reviewed Mar 10, 2021
View reviewed changes
tools/buildsys/Cargo.toml Show resolved Hide resolved
tools/pubsys-setup/Cargo.toml Show resolved Hide resolved
@webern webern merged commit 6bd7729 into bottlerocket-os:develop Mar 10, 2021
@webern webern deleted the tools-tokio-v1 branch March 10, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjkirch tjkirch tjkirch approved these changes

@etungsten etungsten etungsten approved these changes

@srgothi92 srgothi92 srgothi92 approved these changes

@zmrow zmrow Awaiting requested review from zmrow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@webern @tjkirch @srgothi92 @etungsten