ipv6 cluster creation issue in testsys #954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zongzhidanielhu
force-pushed
the
ipfamily_ipv4_issue
branch
from
22a2204 to
d2830e5
Compare
zongzhidanielhu
changed the title
gthao313
reviewed
Dec 23, 2024
zongzhidanielhu
force-pushed
the
ipfamily_ipv4_issue
branch
from
226a7f9 to
908630a
Compare
|
LGTM. Can you fix the checks by following the error messages? thanks! |
gthao313
reviewed
Dec 30, 2024
zongzhidanielhu
force-pushed
the
ipfamily_ipv4_issue
branch
from
80db758 to
32eabc2
Compare
yeazelm
reviewed
Dec 31, 2024
zongzhidanielhu
force-pushed
the
ipfamily_ipv4_issue
branch
from
940407c to
fd0b7e8
Compare
… fix previously wrong ipFamily issue This is the body of the commit: this fix addressed the issue of when create clusters, the ipv6 cluster always has a ipFamily of ipv4 which is wrong. In this commit, a new way of creating cluster is added which is using created yaml file in a certain path. That way we can definite the ipFamily for whether it is ipv6 or ipv4. Fixed feedbacks fixed build
zongzhidanielhu
force-pushed
the
ipfamily_ipv4_issue
branch
from
fd0b7e8 to
b3bcb2e
Compare
rpkelly
reviewed
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
ipv6 variants always have a ipFamily=ipv4
Description of changes:
changed the way of create cluster so that ipv6 has ipFamily=ipv6, ipv4 has ipFamily=ipv4
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.