Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2-resource: add credential-providers and no-proxy settings #953

Merged
merged 1 commit into from
Oct 30, 2024
Merged

ec2-resource: add credential-providers and no-proxy settings #953

merged 1 commit into from
Oct 30, 2024

Conversation

gthao313
Copy link
Member

@gthao313 gthao313 commented Oct 30, 2024 •
edited
Loading

Issue number:
Description of changes:

ec2-resource: add `credential-providers` and `no-proxy` settings

Testing done:

  • Create instances with new settings

  • Run quick and conformance test

x86-64-aws-k8s-130-conformance                                Test                               passed                                                         406                                0                              6797   d54c470e                           2024-10-30T06:51:36Z
 x86-64-aws-k8s-130-ipv6-conformance                           Test                               passed                                                         406                                0                              6797   d54c470e                           2024-10-30T06:52:48Z
 x86-64-aws-k8s-130-ipv6-quick                                 Test                               passed                                                           5                                0                              7198   d54c470e                           2024-10-30T05:04:36Z
 x86-64-aws-k8s-130-quick                                      Test                               passed                                                           5                                0                              7198   d54c470e                           2024-10-30T05:04:41Z
 x86-64-aws-k8s-131-conformance                                Test                               passed                                                         408                                0                              6199   d54c470e                           2024-10-30T06:51:56Z
 x86-64-aws-k8s-131-ipv6-conformance                           Test                               passed                                                         408                                0                              6199   d54c470e                           2024-10-30T06:53:41Z
 x86-64-aws-k8s-131-ipv6-quick                                 Test                               passed                                                           5                                0                              6602   d54c470e                           2024-10-30T05:04:26Z
 x86-64-aws-k8s-131-quick                                      Test                               passed                                                           5                                0                              6602   d54c470e                           2024-10-30T05:04:56Z
 x86-64-aws-k8s-130                                            Resource                           completed                                                                                                                               d54c470e                           2024-10-30T05:02:51Z
 x86-64-aws-k8s-130-ipv6                                       Resource                           completed                                                                                                                               d54c470e                           2024-10-30T05:02:51Z
 x86-64-aws-k8s-131                                            Resource                           completed                                                                                                                               d54c470e                           2024-10-30T05:02:40Z
 x86-64-aws-k8s-131-ipv6                                       Resource                           completed                                                                                                                               d54c470e                           2024-10-30T05:02:41Z

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@gthao313
Copy link
Member Author

This method isn't the best approach to pass custom userdata/settings to instances, but current custom userdata/settings functionality isn't correct since we moved testsys and some tools from bob to twoliter. I opened an issue to track this issue and we should fix it and improve custom userdata mechanism later. #952

@gthao313 gthao313 marked this pull request as ready for review October 30, 2024 17:14
@jpculp jpculp merged commit 9c02930 into bottlerocket-os:develop Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-berning sam-berning sam-berning approved these changes

@jpculp jpculp jpculp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gthao313 @jpculp @sam-berning