testsys-launcher: update inputs to allow multiple assumedby roles #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testsysAdminAssumedBy parameter has been changed from a run time CFNParameter to a build time CDK context. It may be updated either in cdk.json, or by providing ``` cdk deploy --context testsysAdminAssumedBy=comma,seperated,list,of,role,names ``` This value is a comma seperated list of strings in order to support cli inputs
ecpullen
approved these changes
May 30, 2023
jpmcb
approved these changes
May 30, 2023
ginglis13
added a commit
to ginglis13/bottlerocket-test-system
that referenced
this pull request
Jan 10, 2024
PR bottlerocket-os#831 switched from using parameterized roles for assuming the testsys-admin role to assuming this role from context. Update the README instructions for deploying to reflect this. Signed-off-by: Gavin Inglis <[email protected]>
ginglis13
added a commit
to ginglis13/bottlerocket-test-system
that referenced
this pull request
Jan 10, 2024
PR bottlerocket-os#831 switched from using parameterized roles for assuming the testsys-admin role to assuming this role from context. Update the README instructions for deploying to reflect this. Signed-off-by: Gavin Inglis <[email protected]>
ginglis13
added a commit
to ginglis13/bottlerocket-test-system
that referenced
this pull request
Jan 10, 2024
PR bottlerocket-os#831 switched from using parameterized roles for assuming the testsys-admin role to assuming this role from context. Update the README instructions for deploying to reflect this. Signed-off-by: Gavin Inglis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
testsysAdminAssumedBy parameter has been changed from a run time CFNParameter to a build time CDK context. It may be updated either in cdk.json, or by providing
This value is a comma seperated list of strings in order to support cli inputs
Testing done:
Deployed stack to AWS account
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.