samples: small fixes to Makefile variables #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etungsten
approved these changes
Feb 3, 2023
ecpullen
approved these changes
Feb 3, 2023
mjsterckx
force-pushed
the
makefile-variable-fix
branch
from
cd26bf7 to
a4fdf66
Compare
mjsterckx
force-pushed
the
makefile-variable-fix
branch
5 times, most recently
from
9c3613c to
bc7ac26
Compare
webern
approved these changes
Feb 4, 2023
mjsterckx
force-pushed
the
makefile-variable-fix
branch
from
bc7ac26 to
4cb65d1
Compare
mjsterckx
force-pushed
the
makefile-variable-fix
branch
from
4cb65d1 to
9956ac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Removed a redundant env variable, fixed the name of
WORKLOAD_TEST_IMAGE_URI, and simplifiedOUTPUT_FILEsinceCLUSTER_NAMEnow already contains theTEST_TYPEas of #760.Changed the prefix of
VCENTERvariables toGOVCto match what they are called in the rest of TestSys.Testing done:
Started with a clean environment (which I didn't do in #760 and that's why I missed the
WORKLOAD_TEST_IMAGEbug) and generated all samples ineksTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.