ecs-resource-agent: added field for existing profile #555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added field for existing IAM profile to the CRD and code to check if the field contains a value: if so, retrieves the ARN of the submitted profile instead of the default one.
Issue number:
#379
Description of changes:
Added a field to the ecs-resource-agent CRD where a user can enter the name of an existing IAM instance profile. This allows cluster creation without IAM role creation permissions. The ecs-provider code will check if the field is used, and if so, attempt to retrieve the ARN of the submitted profile instead of the default one. If this is unsuccessful (because, for example, the profile does not exist), the ECS creation throws an error.
Testing done:
Provider error: An error occurred but no resources were left behind, The iam instance profile name was not found.: An error left resources behind that can be destroyed, Unable to get instance profile.: NoSuchEntityException: Instance Profile does-not-exist cannot be found.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.