Rerun sonobuoy #352
Merged
Rerun sonobuoy #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecpullen
force-pushed
the
rerun-sonobuoy
branch
from
6dc89dc to
7011a1b
Compare
ecpullen
force-pushed
the
rerun-sonobuoy
branch
from
7011a1b to
5c122b7
Compare
webern
reviewed
Mar 17, 2022
ecpullen
force-pushed
the
rerun-sonobuoy
branch
from
1d60324 to
03bf195
Compare
ecpullen
force-pushed
the
rerun-sonobuoy
branch
from
03bf195 to
2cad8f2
Compare
|
^ rebase to develop |
ecpullen
force-pushed
the
rerun-sonobuoy
branch
from
2cad8f2 to
f4d537d
Compare
webern
approved these changes
Mar 21, 2022
etungsten
approved these changes
Mar 22, 2022
agent/test-agent/src/agent.rs
Outdated
Comment on lines
99
to
102
| let retries = self.client.retries().await.unwrap_or_default(); | ||
| let mut retry_count = 0; | ||
| while test_results.outcome != Outcome::Pass && retry_count < retries { | ||
| info!("Test did not pass, retrying ..."); |
There was a problem hiding this comment.
nit: might be a good idea to log the number of retries/retry # we're about to attempt.
ecpullen
force-pushed
the
rerun-sonobuoy
branch
from
f4d537d to
b8df31d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #181
Description of changes:
Adds a function
rerun_failedto theRunnertrait. Afterrunis called,rerun_failedwill be called up toretriestimes orOutcome::Passis returned.Testing done:
Forced a sonobuoy test to fail and the test was properly rerun.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.