-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs for 1.26.2, 1.27.0 and 1.27.1 #498
Conversation
The preview of the change looks good to me. Note that we introduced FIPS variants in 1.27.0. You might want to check with @arnaldo2792 to get the documentation updated in the "Variants" section. Not blocking though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview LGTM includes 1.26.2, 1.27.0, and 1.27.1 into main.
@@ -0,0 +1,31 @@ | |||
[[docs.ref.config]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we document the behavior of this setting that changed via bottlerocket-os/bottlerocket-core-kit#218 in 1.27.x +?
By default for non-FIPS variants, settings.aws.config
will default to the base64 encoded representation of
[default]
use_fips_endpoint=false
For FIPS variants, this setting will default to the base64 encoded string of
[default]
use_fips_endpoint=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't block on this though - we can follow up with changes for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, these changes will be added in a separate pull request.
Issue number:
Closes # n/a
Description of changes:
Note:
this is all generated from bottlerocket sources.
Reference PR: #496
Terms of contribution:
By submitting this pull request, I confirm that my contribution is made under
the terms of the licenses outlined in the LICENSE-SUMMARY file.