Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to improve caching behavior #6

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

bcressey
Copy link
Contributor

Issue number:
N/A

Description of changes:
#2 didn't actually fix the previous cache workflow, but I'll chalk that up to bottlerocket-os/twoliter#307 and keep going.

This is an experiment to see if we can get useful caching behavior while staying within the 10 GiB overall cache budget.

Testing done:
😬

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

bcressey added 2 commits June 19, 2024 15:53
This tells Twoliter to fetch modules for these projects.

Signed-off-by: Ben Cressey <[email protected]>
This splits up the cache steps to make the cache more useful.

Pull requests will fetch the most recent build cache, if available,
and will not generate caches of their own since the cached artifacts
cannot be easily reused across other branches.

On merge to develop, a shared project-level cache will be refreshed
with the most recent artifacts.

Signed-off-by: Ben Cressey <[email protected]>
Copy link
Contributor

@cbgbt cbgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good setup on paper!

Copy link
Member

@larvacea larvacea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, though I am a poor predictor of what will actually happen in the runner.

@bcressey
Copy link
Contributor Author

Lgtm, though I am a poor predictor of what will actually happen in the runner.

Same! 🤞🏻

@bcressey bcressey merged commit aa1d20d into bottlerocket-os:develop Jun 19, 2024
2 checks passed
@bcressey bcressey deleted the more-cache-fixes branch June 19, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants