set LoaderTimeInitUSec and LoaderTimeExecUSec in GRUB #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport upstream patches from the series that added the Boot Loader Interface module, which implements a different part of the interface: support for LoaderInfo and LoaderDevicePartUUID. The refactoring commits added a new grub_efi_set_variable_to_string function, along with the ability to set a variable without the non- volatile flag applied. Add two patches of our own: one to implement the part of BLI that's used by `systemd-analyze` to report time spent in the firmware and in the bootloader; and another to make it so that grub_get_time_ms() on i386 doesn't treat the time the TSC was calibrated as the epoch for all timestamps, which otherwise hides the time spent between power on and when GRUB is started. Signed-off-by: Ben Cressey <[email protected]>
larvacea
approved these changes
Nov 15, 2024
yeazelm
approved these changes
Nov 18, 2024
arnaldo2792
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #272
Description of changes:
For
systemd-analyzeto report the time spent in firmware and in the boot loader, we need to setLoaderTimeInitUSecandLoaderTimeExecUSec, so the values can be read by efi_loader_get_boot_usec() and set by boot_timestamps().This patch series teaches GRUB to do this for x86 and aarch64. It relies on backported upstream patches from the series that added the Boot Loader Interface module]. That series implemented support for a different part of BLI: the
LoaderInfoandLoaderDevicePartUUIDvariables.Testing done:
Tested this under the different EFI implementations I have access to - edk2 via QEMU/KVM, EC2 Nitro instances, and VMware ESXi VMs.
Verified that
systemd-analyzereports firmware and loader time:Confirmed that the variables aren't marked as non-volatile:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.