Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version v0.7.4 #52

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Version v0.7.4 #52

merged 1 commit into from
Feb 2, 2022

Conversation

jpculp
Copy link
Member

@jpculp jpculp commented Feb 2, 2022

Testing done:

  • Launched aws-ecs-1 ami with new container set in userdata.
  • Enabled the admin container via the control container's APIclient.
  • Verified APIclient exec functionality.
  • Verified Bottlerocket access via sudo sheltie.
  • Connected to admin container via ec2 instance connect.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@jpculp
Copy link
Member Author

jpculp commented Feb 2, 2022

Updated CHANGELOG.md.

@jpculp jpculp marked this pull request as ready for review February 2, 2022 19:50
@jpculp jpculp requested review from cbgbt, etungsten and webern February 2, 2022 19:51
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also test that SSH to the container works? I didn't see that in the testing done.

@jpculp
Copy link
Member Author

jpculp commented Feb 2, 2022

My testing script tests SSH via ec2 instance connect, which generates a one-time-use SSH public key, pushes the key to the instance where it remains for 60 seconds, and connects the user to the instance.

That said, I just launched an instance using normal public key authentication powered by shibaken and it also worked.

@jpculp jpculp requested a review from zmrow February 2, 2022 20:55
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛖

@jpculp jpculp merged commit 3c0c763 into bottlerocket-os:develop Feb 2, 2022
@jpculp jpculp deleted the v0.7.4 branch February 2, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants