Allow setting key exchange algorithms #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an example, to disable diffie-hellman-group1-sha1 and diffie-hellman-group-exchange-sha1 as per https://datatracker.ietf.org/doc/html/draft-ietf-curdle-ssh-kex-sha2-20#page-16 this change allows the customization of key exchange algorithms to remove unsatisfactory algorithms (README.md has an example that meets the requirements)
|
I'll convert this to a proper PR once I can fill the testing done section |
|
Thanks for opening this! |
|
@jpculp this is ready for review when you have some time |
bcressey
approved these changes
Oct 27, 2021
etungsten
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
As an example, to disable diffie-hellman-group1-sha1 and
diffie-hellman-group-exchange-sha1 as per
https://datatracker.ietf.org/doc/html/draft-ietf-curdle-ssh-kex-sha2-20#page-16
this change allows the customization of key exchange algorithms to
remove unsatisfactory algorithms (README.md has an example that meets
the requirements)
Testing done:
Tested creating a bottlerocket host using an inhouse-built admin container - can confirm that KexAlgorithms is correctly set now.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.