Pull bash and musl sources from lookaside cache #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit pulls and verifies sources from the Bottlerocket SDK's lookaside-cache, as opposed to their upstream repositories.
jpculp
commented
May 21, 2021
| @@ -0,0 +1,8 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
We've started to use #!/usr/bin/env bash, but I left this untouched from bottlerocket-sdk/sdk-fetch. Should we just switch both?
There was a problem hiding this comment.
Switching to #!/usr/bin/env bash in bottlerocket-sdk/sdk-fetch seemed to cause issues. I'll keep this as is, at least for now.
etungsten
approved these changes
May 24, 2021
webern
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#1
Description of changes:
This commit pulls and verifies sources from the Bottlerocket SDK's "lookaside-cache", as opposed to their upstream repositories.
Testing done:
aws-ecs-1instance.sudo sheltieto verify root shell was still available.$0 --versionto verify correct build version 5.0.18.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.