explicit virtual addressing presigning bug #3081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3081 +/- ##
===========================================
- Coverage 93.47% 93.13% -0.34%
===========================================
Files 66 66
Lines 14038 14239 +201
===========================================
+ Hits 13122 13262 +140
- Misses 916 977 +61 ☔ View full report in Codecov by Sentry. |
nateprewitt
approved these changes
Dec 4, 2023
aws-sdk-python-automation
added a commit
that referenced
this pull request
Dec 5, 2023
* release-1.33.8: Bumping version to 1.33.8 Update to latest models explicit virtual addressing presigning bug (#3081) Update pre-commit versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug introduced with the endpoints refactor from last year. Previously, if a customer had explicitly set
addressing_styletovirtualin their s3 config, the SDK ignored theuse_global_endpointsetting on the request context. Instead, it would use the endpoint URL from the legacy endpoint resolver which was always regionalized except in the cases ofaws-globalandus-east-1. This has caused some issues where a regional endpoint is expected when using signature version 4 to sign URLs.It was likely missed during the refactor because it followed a confusing codepath that was decoupled from
_should_use_global_endpoint. For clarity and simplicity, a simple check is added to the function.