Append aws-chunked to Content-Encoding header if present
#2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 93.54% // Head: 93.55% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #2859 +/- ##
========================================
Coverage 93.54% 93.55%
========================================
Files 63 63
Lines 13398 13400 +2
========================================
+ Hits 12533 12536 +3
+ Misses 865 864 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nateprewitt
reviewed
Jan 30, 2023
nateprewitt
reviewed
Jan 31, 2023
|
@nateprewitt I'll wait until #2860 is merged, then I'll update the functional test to rely on the defaults in the client constructor. |
dlm6693
force-pushed
the
content-encoding
branch
from
8661111 to
6a52ac3
Compare
nateprewitt
reviewed
Jan 31, 2023
…parate line in functional test
nateprewitt
approved these changes
Jan 31, 2023
Looks good once the tests wrap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily in various S3 operations, users may provide a
ContentEncodingparameter. This tells the service how the content that is being sent/requested is encoded. An example of this would begzip. However, for streaming AWS operations (i.e. ones that have trailers) where aChecksumAlgorithmparameter is provided, the SDK is currently overriding any user input toaws-chunked. Instead this special content encoding should be appended to the user input.