arn resource delimiter regex to string methods #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 93.53% // Head: 93.51% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2834 +/- ##
===========================================
- Coverage 93.53% 93.51% -0.03%
===========================================
Files 63 63
Lines 13382 13381 -1
===========================================
- Hits 12517 12513 -4
- Misses 865 868 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jonemo
approved these changes
Dec 13, 2022
aws-sdk-python-automation
added a commit
that referenced
this pull request
Dec 13, 2022
* release-1.29.29: Bumping version to 1.29.29 Update to latest partitions and endpoints Update to latest models arn resource delimiter regex to string methods (#2834) Add Type field for query errors from JSON protocol
kyleknap
added a commit
to kyleknap/aws-cli
that referenced
this pull request
Dec 13, 2022
Specifically, the previous implementation did not handle ARNs that use both colon and slashes as delimeters. This is a port from the original implementation across the following PRs: * boto/botocore#2831 * boto/botocore#2834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2831. While there was nothing wrong with it, splitting a string using a compiled regular expression object is significantly slower (roughly 3x) than using plain Python string manipulation methods.