Deprecate SSL common name #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 93.57% // Head: 93.42% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2804 +/- ##
===========================================
- Coverage 93.57% 93.42% -0.15%
===========================================
Files 63 63
Lines 13305 13300 -5
===========================================
- Hits 12450 12426 -24
- Misses 855 874 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nateprewitt
reviewed
Nov 1, 2022
|
@nateprewitt just pushed up the changelog. Also should mention I ran integration tests and didn't see any failures. |
nateprewitt
approved these changes
Nov 1, 2022
aws-sdk-python-automation
added a commit
that referenced
this pull request
Nov 1, 2022
* release-1.29.0: Bumping version to 1.29.0 Update to latest models use legacy resolver as source of default region name (#2805) Deprecate SSL common name (#2804) Enable endpoint resolution 2.0 for all services (#2802) Endpoint resolution v2 for Eventbridge (#2788) Supports versioned endpointsV2 files Add test cases for new endpoint models Add endpoint-rule-set-1.json files for every service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR formally deprecates the usage of
sslCommonNamein endpoint resolution. This was a legacy codepath back when botocore supported python < 2.7. At this time python did not provide a SSL module, meaning certain certificate formats were needed. Now that new endpoint resolution via ruleset files has been released, this format is no longer necessary.Please see #2705 for additional details.