Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move endpoint tests into correct position #2782

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Move endpoint tests into correct position #2782

merged 1 commit into from
Oct 19, 2022

Conversation

nateprewitt
Copy link
Contributor

Relocate s3/s3control endpoint test files into the testing directory instead of the base model directory for each service.

@nateprewitt nateprewitt requested a review from jonemo October 19, 2022 20:55
jonemo
jonemo approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@jonemo jonemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022 •
edited
Loading

Codecov Report

Base: 95.25% // Head: 95.25% // No change to project coverage 👍

Coverage data is based on head (30a4b24) compared to base (48b0699).
Patch has no changes to coverable lines.

❗ Current head 30a4b24 differs from pull request most recent head 9d75837. Consider uploading reports for the commit 9d75837 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2782   +/-   ##
========================================
  Coverage    95.25%   95.25%           
========================================
  Files           62       62           
  Lines        12907    12907           
========================================
  Hits         12295    12295           
  Misses         612      612

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nateprewitt nateprewitt merged commit 6231347 into boto:develop Oct 19, 2022
@nateprewitt nateprewitt deleted the test_move branch October 19, 2022 22:02
aws-sdk-python-automation added a commit that referenced this pull request Oct 20, 2022
@aws-sdk-python-automation
Merge branch 'release-1.27.95'
baf3fd3 
* release-1.27.95:
  Bumping version to 1.27.95
  Update to latest endpoints
  Update to latest models
  gzip rule set files for wheel (#2780)
  Move endpoint tests into correct position (#2782)
  Update to latest s3 endpoint models
  Update to latest s3control endpoint models
@jonemo jonemo mentioned this pull request Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonemo jonemo jonemo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nateprewitt @codecov-commenter @jonemo