Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tcp_keepalive to config_kwargs #2771

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Conversation

miketheman
Copy link
Contributor

The tcp_keepalive parameter was added to the Config object in #2766 When inspecting the return value of an instantiated Client's meta with the config, it is always None.

Does not handle resolving whether the value has been set in scoped_config.

The `tcp_keepalive` parameter was added to the Config object in boto#2766
When inspecting the return value of an instantiated Client's `meta` with the config, it is always `None`.

Does not handle resolving whether the value has been set in `scoped_config`.
Copy link
Contributor

@dlm6693 dlm6693 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for catching and submitting this so quickly @miketheman!

@dlm6693 dlm6693 merged commit 730f1eb into boto:develop Oct 3, 2022
@miketheman miketheman deleted the patch-1 branch October 3, 2022 23:03
aws-sdk-python-automation added a commit that referenced this pull request Oct 4, 2022
* release-1.27.86:
  Bumping version to 1.27.86
  Update to latest endpoints
  Update to latest models
  add tcp_keepalive to config_kwargs (#2771)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants