-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit test for endpoint resolution caching #2770
Conversation
Codecov ReportBase: 93.49% // Head: 93.47% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2770 +/- ##
===========================================
- Coverage 93.49% 93.47% -0.03%
===========================================
Files 63 63
Lines 13350 13350
===========================================
- Hits 12482 12479 -3
- Misses 868 871 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is still lingering. Left a couple comments, let me know if we still needed this.
a9ca7f9
to
f3e21d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a debugging leftover snuck into the diff. Once that is removed this is good to merge 🚀
Edit: And since you have to touch it again anyway, can you also rebase from develop
to make the CI failure go away?
16257dc
to
a22e46e
Compare
* release-1.29.20: Bumping version to 1.29.20 Update to latest partitions and endpoints Update to latest models add unit test for endpoint resolution caching (#2770)
This PR adds a unit test for endpoint resolution caching, which the test suite did not previously include.