Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for endpoint resolution caching #2770

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

dlm6693
Copy link
Contributor

@dlm6693 dlm6693 commented Sep 29, 2022

This PR adds a unit test for endpoint resolution caching, which the test suite did not previously include.

@dlm6693 dlm6693 requested a review from jonemo September 29, 2022 17:05
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Base: 93.49% // Head: 93.47% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (16257dc) compared to base (507274b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2770      +/-   ##
===========================================
- Coverage    93.49%   93.47%   -0.03%     
===========================================
  Files           63       63              
  Lines        13350    13350              
===========================================
- Hits         12482    12479       -3     
- Misses         868      871       +3     
Impacted Files Coverage Δ
botocore/httpsession.py 91.40% <0.00%> (-0.40%) ⬇️
botocore/utils.py 79.07% <0.00%> (-0.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is still lingering. Left a couple comments, let me know if we still needed this.

@dlm6693 dlm6693 force-pushed the endpoint-provider-caching-test branch from a9ca7f9 to f3e21d8 Compare November 28, 2022 16:47
Copy link
Contributor

@jonemo jonemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a debugging leftover snuck into the diff. Once that is removed this is good to merge 🚀

Edit: And since you have to touch it again anyway, can you also rebase from develop to make the CI failure go away?

@dlm6693 dlm6693 force-pushed the endpoint-provider-caching-test branch from 16257dc to a22e46e Compare November 29, 2022 20:07
@dlm6693 dlm6693 merged commit 85499a8 into boto:develop Nov 30, 2022
@dlm6693 dlm6693 deleted the endpoint-provider-caching-test branch November 30, 2022 15:15
aws-sdk-python-automation added a commit that referenced this pull request Nov 30, 2022
* release-1.29.20:
  Bumping version to 1.29.20
  Update to latest partitions and endpoints
  Update to latest models
  add unit test for endpoint resolution caching (#2770)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants