Deprecate ssl common name #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlm6693
force-pushed
the
deprecate-ssl-common-name
branch
2 times, most recently
from
da55941 to
544979c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2738 +/- ##
========================================
Coverage 95.25% 95.26%
========================================
Files 60 60
Lines 12278 12285 +7
========================================
+ Hits 11696 11703 +7
Misses 582 582
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dlm6693
force-pushed
the
deprecate-ssl-common-name
branch
4 times, most recently
from
d276304 to
aafb5ee
Compare
dlm6693
force-pushed
the
deprecate-ssl-common-name
branch
from
aafb5ee to
d9fc6db
Compare
nateprewitt
reviewed
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that aws/aws-cli#7114 is close to full approval, this should be re-opened and merged to deprecate the SSL common name paradigm in botocore. This is a copy of https://github.com/boto/botocore/pull/2704/files which had to be rolled back because of unforeseen issues it caused in aws-cli v1.