Warn users of sslCommonName deprecation.
#2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2704 +/- ##
========================================
Coverage 95.22% 95.23%
========================================
Files 60 60
Lines 12283 12290 +7
========================================
+ Hits 11697 11704 +7
Misses 586 586
Continue to review full report at Codecov.
|
dlm6693
force-pushed
the
deprecate-ssl-common-name
branch
2 times, most recently
from
66d6567 to
55848b5
Compare
nateprewitt
requested changes
Jun 21, 2022
joguSD
reviewed
Jun 22, 2022
botocore/client.py
Outdated
| f'The {service_name} client is currently using a ' | ||
| f'deprecated endpoint: {sslCommonName}. In the next ' | ||
| f'minor version this will be moved to {hostname}. ' | ||
| 'See https://github.com/boto/botocore/issues/2376 ' |
There was a problem hiding this comment.
Perhaps it might be better if we create an issue that's a bit more explicit on the what/why surrounding this deprecation. It feels a little weird to link to a closed issue that doesn't really explain the deprecation beyond describing one of the affected services.
There was a problem hiding this comment.
Yeah that makes sense I'll make one
dlm6693
force-pushed
the
deprecate-ssl-common-name
branch
4 times, most recently
from
f2cb691 to
cd1e8b4
Compare
nateprewitt
requested changes
Jun 28, 2022
dlm6693
force-pushed
the
deprecate-ssl-common-name
branch
from
d3534c8 to
e3ef3d9
Compare
nateprewitt
added a commit
to nateprewitt/botocore
that referenced
this pull request
Jun 28, 2022
nateprewitt
added a commit
that referenced
this pull request
Jun 29, 2022
aws-sdk-python-automation
added a commit
that referenced
this pull request
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This somewhat addresses #2376. Since we changes to endpoints are coming soon, we aren't addressing the root of the problem at the moment, but sending a warning that it will be soon.