sse for SelectObjectCount s3 op #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2700 +/- ##
========================================
Coverage 95.25% 95.25%
========================================
Files 60 60
Lines 12278 12278
========================================
Hits 11696 11696
Misses 582 582
Continue to review full report at Codecov.
|
aws-sdk-python-automation
added a commit
that referenced
this pull request
Jun 21, 2022
* release-1.27.14: Bumping version to 1.27.14 Update to latest models sse encoding for SelectObjectCount s3 op (#2700)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses boto/boto3#3268. Discussion about supporting SSE for all s3 ops was discussed, but the service only supports it for 11 out of its 97 APIs/ops.
A manual integration test was performed before and after registering the handler for
SelectObjectContent. Before the same exceptionbotocore.exceptions.ClientError: An error occurred (AccessDenied) when calling the SelectObjectContent operation: Access Deniedwas raised that the user in the original issue highlighted. After, the call succeeded.