Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples #2689

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Update examples #2689

merged 1 commit into from
Jun 2, 2022

Conversation

stealthycoin
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

Merging #2689 (b4081b4) into develop (36eaad6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2689   +/-   ##
========================================
  Coverage    95.29%   95.29%           
========================================
  Files           60       60           
  Lines        12252    12252           
========================================
  Hits         11676    11676           
  Misses         576      576           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36eaad6...b4081b4. Read the comment docs.

@stealthycoin stealthycoin requested a review from nateprewitt May 31, 2022 19:42
Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of quick questions, otherwise looks good.

@@ -1,1513 +1,5 @@
{
"version": "1.0",
"examples": {
"AddLayerVersionPermission": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is deleting all of our Lambda examples. We may want to double check on this before merging.

@@ -62,42 +63,6 @@
"id": "to-retreive-attribute-values",
"title": "To retrieve a list of attribute values"
}
],
"GetProducts": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another one where we're completely deleting an operation example. Does this need to be upstreamed?

Sync examples with upstream source.
Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@stealthycoin stealthycoin merged commit c7d4e40 into boto:develop Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants