iox-eclipse-iceoryx#337 remove the explicit call for the semaphore de…

…structor within timer Signed-off-by: Sankara Narayanan Chandrasekar (RBEI/EMT2) <[email protected]>
boschglobal · Apr 27, 2021 · e5554a3 · e5554a3
1 parent 694b53b
commit e5554a3
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/iceoryx_utils/include/iceoryx_utils/cxx/timer.hpp b/iceoryx_utils/include/iceoryx_utils/cxx/timer.hpp
@@ -78,7 +78,7 @@ class Timer
     Timer(const iox::units::Duration interval, const iox::units::Duration delayThreshold = 0_ms) noexcept;
 
     /// @brief Stops and joins the thread spawned by the constructor.
-    ~Timer() noexcept;
+    virtual ~Timer() noexcept = default;
 
     /// @brief (re-)Starts the timer. This also calculates the time until the timer goes to sleep and next time of
     /// activation. This also acquires the binary semaphore.

diff --git a/iceoryx_utils/source/cxx/timer.cpp b/iceoryx_utils/source/cxx/timer.cpp
@@ -27,11 +27,6 @@ Timer::Timer(const iox::units::Duration interval, const iox::units::Duration del
     start();
 }
 
-Timer::~Timer() noexcept
-{
-    m_waitSemaphore.~Semaphore();
-}
-
 void Timer::start() noexcept
 {
     stop();