Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HYBRID mode and support for arbitrarily large files #5

Open
wants to merge 72 commits into
base: master
Choose a base branch
from

Conversation

piotrmaslanka
Copy link

@piotrmaslanka piotrmaslanka commented May 12, 2021

I've added a new mode, called HYBRID.

This mode enables to use a ZooKeeper system as a full fledged filesystem. Namely, the instance of zookeeper-fuse that creates a file remembers whether it created it as a file or a directory, which enables the nodes to better mirror the filesystem/directory parallelity.

I've implemented it working on my pet project zookeeper-volume. You should totally check it out, and maybe leave a star!

However, there is a todo - it uses cache, but I've neglected to implement cache eviction. Fortunately, if you're using the same files over and over (which is my use case) the solution will hold.

@piotrmaslanka piotrmaslanka marked this pull request as ready for review May 12, 2021 18:17
@piotrmaslanka
Copy link
Author

I've decided to add symlink support, so just hold tight until I do that.

@piotrmaslanka piotrmaslanka force-pushed the master branch 15 times, most recently from 07f819f to e0f829c Compare May 12, 2021 20:13
@piotrmaslanka
Copy link
Author

piotrmaslanka commented Aug 5, 2021

I also added Travis, a nicer readme and capability to mv empty directories, and capability to read files of any size.

@piotrmaslanka piotrmaslanka changed the title HYBRID mode HYBRID mode and support for arbitrarily large files Aug 5, 2021
@piotrmaslanka
Copy link
Author

Hey @borowskk how's the progress on that pull request? The software is happily working away on powering https://smok.co certificate system in a masterless 3-node setup.

@borowskk
Copy link
Owner

Hey @borowskk how's the progress on that pull request? The software is happily working away on powering https://smok.co certificate system in a masterless 3-node setup.

I spent some time this AM reviewing the changes and think the bulk of my review is done. I had some trouble with that signed/unsigned problem so I haven't got a chance to really play with the behavior and give it a test.

Generally it looks like a cool concept. Thanks for contributing.

@borowskk
Copy link
Owner

I had a bit more time so I was able to take the hybrid mode out for a spin after making a small change to work around the signed/unsigned issue. Tested the symlinks creation/restore, the behavior of creating files/folders, etc. it seems to work good. Nice work! I'll merge if you fix the things identified. If not, no worries, maybe someday I'll come back and address them myself and then merge.

Copy link
Owner

@borowskk borowskk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I'll merge if you fix the things identified. If not, no worries, maybe someday I'll come back and address them myself and then merge.

@piotrmaslanka
Copy link
Author

Ok, I'll eventually get back to it in my infinite free time.

@piotrmaslanka
Copy link
Author

@borowskk over to you, good sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants