Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docs for database restore params and config bootstrap #74

Merged
merged 3 commits into from
Jul 31, 2023
Merged

add docs for database restore params and config bootstrap #74

merged 3 commits into from
Jul 31, 2023

Conversation

diivi
Copy link
Collaborator

@diivi diivi commented Jul 15, 2023

image
image

witten
witten requested changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@witten witten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is looking good, especially the database changes. I added several suggestions to the bootstrap section though; I feel like it could probably use a few more details in places. Anyway, thank you for doing these docs!

docs/how-to/backup-your-databases.md Outdated Show resolved Hide resolved
docs/how-to/backup-your-databases.md Outdated Show resolved Hide resolved
docs/how-to/backup-your-databases.md Outdated Show resolved Hide resolved
docs/how-to/extract-a-backup.md Outdated Show resolved Hide resolved
docs/how-to/extract-a-backup.md Outdated Show resolved Hide resolved
docs/how-to/extract-a-backup.md Outdated Show resolved Hide resolved
docs/how-to/extract-a-backup.md Outdated Show resolved Hide resolved
docs/how-to/extract-a-backup.md Outdated Show resolved Hide resolved
docs/how-to/extract-a-backup.md Outdated Show resolved Hide resolved
docs/how-to/extract-a-backup.md Outdated Show resolved Hide resolved
@diivi diivi requested a review from witten July 28, 2023 18:46
witten
witten requested changes Jul 30, 2023
View reviewed changes
Copy link
Collaborator

@witten witten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. A couple minor tweaks and then I think we're done!

docs/how-to/extract-a-backup.md Outdated Show resolved Hide resolved
docs/how-to/extract-a-backup.md Outdated Show resolved Hide resolved
docs/how-to/extract-a-backup.md Outdated Show resolved Hide resolved
@witten witten merged commit 88adb5b into borgmatic-collective:main Jul 31, 2023
@witten
Copy link
Collaborator

witten commented Jul 31, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@witten witten witten requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diivi @witten